Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating tests for node 20 compatibility #782

Merged
merged 30 commits into from
Nov 13, 2023
Merged

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Oct 17, 2023

Description

Because Node 16 has been officially deprecated, this PR brings all the tooling up to date with the current stable release of Node 20. Backwards support for Node >14 is maintained via our tsconfig, but changes to how Jest snapshots work mean that we can't run the tests successfully below Node 17.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner October 17, 2023 00:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

size-limit report 📦

Path Size
@dfinity/agent 98.17 KB (0%)
@dfinity/candid 13.41 KB (0%)
@dfinity/principal 5.01 KB (0%)
@dfinity/auth-client 90.53 KB (0%)
@dfinity/assets 91.07 KB (0%)
@dfinity/identity 88.01 KB (0%)
@dfinity/identity-secp256k1 253.89 KB (+1.81% 🔺)

@krpeacock krpeacock enabled auto-merge (squash) November 8, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant